gh-132542: Set native thread ID after fork #132701
Open
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 6ebd095 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132701%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
gpshead
reviewed
Apr 27, 2025
| print(threading.current_thread().native_id, flush=True) | ||
| assert threading.current_thread().native_id == threading.get_native_id() | ||
| else: | ||
| assert parent_thread_native_id == threading.current_thread().native_id |
There was a problem hiding this comment.
Since you want to assert on the child's output, explicitly wait for the child process.
try:
... asserts ...
finally:
os.waitpid(child_pid)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most of Python's runtime state, including thread-related data, is only consistent after
PyOS_AfterFork_Child()is called, updatingnative_idin theafter_forkhandler ensures correctness and aligns with Python’s existing fork-handling mechanisms.