Skip to content

gh-132776: Minor Fixes for XIBufferViewType #132779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

gh-132776: Minor Fixes for XIBufferViewType #132779

merged 4 commits into from
Apr 22, 2025

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 21, 2025 •
edited by bedevere-app bot
Loading

This change covers the following:

  • dealloc: no cleanup if no buffer set
  • dealloc: handle already-destroyed interpreter correctly
  • handle errors in _memoryview_from_xid() correctly
  • clean up the buffer if the xidata is never used

@bedevere-app bedevere-app bot mentioned this pull request Apr 21, 2025
Closed
@ericsnowcurrently ericsnowcurrently merged commit b5bf8c8 into python:main Apr 22, 2025
41 checks passed
@ericsnowcurrently ericsnowcurrently deleted the fix-xibufferview-clean-up-if-not-used branch April 22, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericsnowcurrently