gh-132713: Fix typing.Union[index] race condition #132802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a critical section in union_getitem() to initialize the 'parameters' member.
sobolevn
reviewed
Apr 22, 2025
Add union_init_parameters() helper function.
|
Please review the updated PR. |
kumaraditya303
approved these changes
Apr 23, 2025
sobolevn
approved these changes
Apr 23, 2025
|
"All required checks pass" CI didn't run. I updated my branch to try to fix the CI. |
|
Merged, thanks for reviews. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 23, 2025
) Add union_init_parameters() helper function. Use a critical section to initialize the 'parameters' member. (cherry picked from commit dc3e963) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-132839 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a critical section in union_getitem() to initialize the 'parameters' member.
union_reprfromlist_repr_implin free-threaded build #132713