Skip to content

gh-132776: Cleanup for XIBufferViewType #132821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 23, 2025

  • add notes
  • rename XIBufferViewObject to xibufferview
  • move memoryview XIData code to memoryobject.c

@ericsnowcurrently ericsnowcurrently merged commit e54e828 into python:main Apr 25, 2025
45 checks passed
@ericsnowcurrently ericsnowcurrently deleted the xibufferview-cleanup branch April 25, 2025 00:25
@vstinner
Copy link
Member

This change introduced memory leaks. Examples:

$ ./python -m test test__interpchannels -R 3:3 -m test_send_buffer_blocking_waiting
...
test__interpchannels leaked [2, 2, 2] references, sum=6
...

$ ./python -m test test_interpreters -R 3:3 -m test_from_subinterpreter
...
test_interpreters leaked [11, 11, 11] references, sum=33
test_interpreters leaked [9, 9, 9] memory blocks, sum=27
...

@ericsnowcurrently
Copy link
Member Author

I've created a PR with a fix: gh-132960.

ericsnowcurrently added a commit that referenced this pull request Apr 25, 2025
…-132960)

This is a partial revert of gh-132821.  It resolves the refleak introduced by that PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants