gh-131798: JIT: Split CALL_TUPLE_1 into several uops #132851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
commented
Apr 24, 2025
Comment on lines
+961
to
+964
| if (sym_matches_type(arg, &PyTuple_Type)) { | ||
| // e.g. tuple((1, 2)) or tuple(foo) where foo is known to be a tuple | ||
| res = arg; | ||
| } |
There was a problem hiding this comment.
Same optimization as in #132849 (comment)
| x = 0 | ||
| for _ in range(n): | ||
| y = tuple((1, 2)) # tuple argument | ||
| a, _ = y # _UNPACK_SEQUENCE_TWO_TUPLE |
There was a problem hiding this comment.
I needed to use UNPACK_SEQUENCE(_TWO)_TUPLE here since it is currently the only uop that propagates the tuple items to the result.
There was a problem hiding this comment.
Nice observation. Seems like _BINARY_OP_SUBSCR_TUPLE_INT could be taught how to do this pretty easily for a constant RHS. Want to add that to your queue?
There was a problem hiding this comment.
It's already in the queue 😄
Fidget-Spinner
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CALL_TUPLE_1is equivalent totuple(...).Very similar to previous work on splitting up
CALL_TYPE_1: #132419This splits the instruction into a smaller instruction + 2 guards which can be optimized away. This also sets the return type to
tuple.