Skip to content

gh-67766: Improve struct.pack out of range error messages #132857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-67766: Improve struct.pack out of range error messages #132857

wants to merge 5 commits into from
+54 −43

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Apr 23, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 23, 2025
Open
@StanFromIreland
Copy link
Contributor Author

Request: @meadori (Though I think the expert may be inactive :-( )

skirpichev
skirpichev reviewed Apr 24, 2025
View reviewed changes
skirpichev
skirpichev approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't like you added argument index to the module state, but alternatives looks more complex.

CC @serhiy-storchaka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @skirpichev