[3.13] Use os.openpty() instead of pty.openpty() in test_ioctl #132878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pty.openpty() does not work on Android, and it is easier to check availability of os.openpty.
|
!buildbot Android |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit af45ba0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132878%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
See #132848 (comment). It is weird that only 3.13 fails. I am going to apply the same change to main after testing it for 3.13. There is no benefit of using pty.openpty() over os.openpty(), because the tests fail if os.openpty() does not work. |
vstinner
approved these changes
Apr 24, 2025
|
This is because the issue can only be reproduced in 3.13, so it is not possible to test the solution in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pty.openpty() does not work on Android, and it is easier to check availability of os.openpty.