Skip to content

gh-63882: Implement some test_minidom tests #132879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 26, 2025
Merged

gh-63882: Implement some test_minidom tests #132879

merged 6 commits into from
Apr 26, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Apr 24, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Apr 24, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 24, 2025
Open
@hugovk
Copy link
Member

hugovk commented Apr 24, 2025

Please include the original patch author in a Co-authored-by trailer.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

StanFromIreland and others added 2 commits April 24, 2025 16:45
@StanFromIreland @JulianGindi
Apply patch
6c5b9b0 
Co-authored-by: Julian Gindi <julian@gindi.io>
@StanFromIreland
Clean up
ec9c382
@StanFromIreland

This comment was marked as resolved.

Sign in to view
hugovk
hugovk reviewed Apr 25, 2025
View reviewed changes
@StanFromIreland @hugovk
Update Lib/test/test_minidom.py
df9feb8 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
picnixz
picnixz reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments concerning unlink but AFAIK, this is only used to break internal references within the DOM itself. Since the objects are either discarded at the end of the function or are small, you might also forget about calling .unlink. OTOH, we can be consistent with the existing tests and always call unlink in an addCleanup instead.

StanFromIreland and others added 2 commits April 25, 2025 15:53
@StanFromIreland @picnixz
Apply suggestions from code review
c3b759c 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@StanFromIreland
Benedikt's suggestions
540a359
hugovk
hugovk approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

picnixz
picnixz approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have a question.

@StanFromIreland
Copy link
Contributor Author

Question has been resolved.

@picnixz picnixz self-assigned this Apr 26, 2025
@picnixz
Copy link
Member

picnixz commented Apr 26, 2025

@hugovk I'll actually let you write the commit message as I don't know how you want the original patch's author to be credited.

@picnixz picnixz removed their assignment Apr 26, 2025
@StanFromIreland StanFromIreland mentioned this pull request Apr 26, 2025
Merged
@hugovk hugovk merged commit ee033d4 into python:main Apr 26, 2025
38 checks passed
@hugovk
Copy link
Member

hugovk commented Apr 26, 2025

Thanks, just to make sure the Co-authored-by was in the commit description.

@hugovk hugovk added the needs backport to 3.13 bugs and security fixes label Apr 26, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2025
@StanFromIreland @JulianGindi
@hugovk @picnixz @miss-islington
pythongh-63882: Implement some test_minidom tests (pythonGH-132879)
0496125 
(cherry picked from commit ee033d4)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Julian Gindi <julian@gindi.io>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 26, 2025

GH-133029 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 26, 2025
@StanFromIreland StanFromIreland deleted the apply-patch branch April 26, 2025 20:07
@StanFromIreland
Copy link
Contributor Author

It should have been auto populated by gh I believe?

hugovk added a commit that referenced this pull request Apr 26, 2025
@miss-islington @StanFromIreland
@JulianGindi @hugovk @picnixz
[3.13] gh-63882: Implement some test_minidom tests (GH-132879) (#13…
fdcaaad 
…3029)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Julian Gindi <julian@gindi.io>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.13 (tier-3) has failed when building commit fdcaaad.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1386/builds/1246) and take a look at the build logs.
  4. Check if the failure is related to this commit (fdcaaad) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1386/builds/1246

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/threading.py", line 1041, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/threading.py", line 992, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

@StanFromIreland
Copy link
Contributor Author

Unrelated fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@picnixz picnixz picnixz approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StanFromIreland @hugovk @picnixz @bedevere-bot