Skip to content

Use os.openpty() instead of pty.openpty() in test_ioctl #132880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Use os.openpty() instead of pty.openpty() in test_ioctl #132880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions Lib/test/test_ioctl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
fcntl = import_module('fcntl')
termios = import_module('termios')

try:
import pty
except ImportError:
pty = None

class IoctlTestsTty(unittest.TestCase):
@classmethod
def setUpClass(cls):
Expand Down Expand Up @@ -136,10 +131,10 @@ def test_ioctl_mutate_2048(self):
self.assertRaises(ValueError, self._check_ioctl_not_mutate_len, 2048)


@unittest.skipIf(pty is None, 'pty module required')
@unittest.skipUnless(hasattr(os, 'openpty'), "need os.openpty()")
class IoctlTestsPty(unittest.TestCase):
def setUp(self):
self.master_fd, self.slave_fd = pty.openpty()
self.master_fd, self.slave_fd = os.openpty()
self.addCleanup(os.close, self.slave_fd)
self.addCleanup(os.close, self.master_fd)

Expand Down
Loading