gh-132930: Implement PEP 773 #132931
Merged
gh-132930: Implement PEP 773 #132931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
reviewed
Apr 26, 2025
Comment on lines
+213
to
+221
| elif ns.include_chm: | ||
| STD_PEP514[0]["Help"]["Main Python Documentation"] = { | ||
| "_": rf"%PREFIX%Doc\{PYTHON_CHM_NAME}", | ||
| } | ||
| STD_START[0]["Items"].append({ | ||
| "Name": f"{DISPLAY_NAME} {VER_DOT} Manuals{DISPLAY_SUFFIX}", | ||
| "Target": "%WINDIR%hhc.exe", | ||
| "Arguments": rf"%PREFIX%Doc\{PYTHON_CHM_NAME}", | ||
| }) |
There was a problem hiding this comment.
I had thought we removed CHM ages ago?
There was a problem hiding this comment.
This script can be used to repackage releases a long way back, so it still has the support in there. Even though it lives in the repo alongside a particular version, it is pretty independent of the actual version it's laying out.
|
I'm going to merge this, as I need it to finish up the release scripts which need the most testing. Happy to take more comments here if people spot things that ought to be fixed (the launcher change will get backported eventually, but not directly from this PR.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily docs and deprecation warnings here, as the Python install manager will go into a separate repository.
Biggest change is adding support to the PC/layout script. The changes to use this script will go in the release-tools repository (and will also support using the latest script when repackaging older versions, so no need to backport).
📚 Documentation preview 📚: https://cpython-previews--132931.org.readthedocs.build/