gh-132908: add math.normal/subnormal() functions #132935
Open
+157
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc/NEWS.d/next/Library/2025-04-25-16-06-53.gh-issue-132908.wV5rja.rst
Outdated
Show resolved
Hide resolved
skirpichev
commented
Apr 25, 2025
Misc/NEWS.d/next/Library/2025-04-25-16-06-53.gh-issue-132908.wV5rja.rst
Outdated
Show resolved
Hide resolved
skirpichev
commented
Apr 25, 2025
skirpichev
commented
Apr 25, 2025
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
So, we have some known buildbots issues. I'll wait for it to be solved and then once it's ok for them, I'll merge it. |
|
Technically it's very trivial pr, yet I would appreciate a second look from someone. Maybe we should be more vague and not define in any way normal/subnormal meaning (i.e. not reference sys.float_info). (Or mention this as CPython implementation detail.) E.g. should all Python implementations support subnormals? |
StanFromIreland
approved these changes
Apr 25, 2025
skirpichev
commented
Apr 28, 2025
Comment on lines
+56
to
+57
| :func:`isnormal(x) <isnormal>` Check if *x* is a normal floating-point number | ||
| :func:`issubnormal(x) <issubnormal>` Check if *x* is a subnormal floating-point number |
There was a problem hiding this comment.
Suggested change
| :func:`isnormal(x) <isnormal>` Check if *x* is a normal floating-point number | |
| :func:`issubnormal(x) <issubnormal>` Check if *x* is a subnormal floating-point number | |
| :func:`isnormal(x) <isnormal>` Check if *x* is a normal number | |
| :func:`issubnormal(x) <issubnormal>` Check if *x* is a subnormal number |
Comment on lines
+381
to
+383
| Return ``True`` if *x* is a normal floating-point number, that is a finite | ||
| nonzero number that is not a subnormal (see :func:`issubnormal`). | ||
| Return ``False`` otherwise. |
There was a problem hiding this comment.
Suggested change
| Return ``True`` if *x* is a normal floating-point number, that is a finite | |
| nonzero number that is not a subnormal (see :func:`issubnormal`). | |
| Return ``False`` otherwise. | |
| Return ``True`` if *x* is a normal number, that is a finite | |
| nonzero number that is not a subnormal (see :func:`issubnormal`). | |
| Return ``False`` otherwise. |
Comment on lines
+390
to
+392
| Return ``True`` if *x* is a subnormal floating-point number, that is a finite | ||
| nonzero number with a magnitude smaller than the smallest positive normal | ||
| number, see :data:`sys.float_info.min`. Return ``False`` otherwise. |
There was a problem hiding this comment.
Suggested change
| Return ``True`` if *x* is a subnormal floating-point number, that is a finite | |
| nonzero number with a magnitude smaller than the smallest positive normal | |
| number, see :data:`sys.float_info.min`. Return ``False`` otherwise. | |
| Return ``True`` if *x* is a subnormal number, that is a finite | |
| nonzero number with a magnitude smaller than the smallest positive normal | |
| number, see :data:`sys.float_info.min`. Return ``False`` otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--132935.org.readthedocs.build/