Skip to content

Remove duplicate check for self.cdata_elem in HTMLParser #132944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

muglug
Copy link

@muglug muglug commented Apr 25, 2025

This was already checked in the line above.

This was already checked in the line above
@muglug muglug requested a review from ezio-melotti as a code owner April 25, 2025 14:27
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 25, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Apr 25, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz
Copy link
Member

picnixz commented Apr 25, 2025

The PR should be open against main, not 3.13. Or is main not affected by this change? if this is the case, we won't backport it as it's a slight optimization rather than a bugfix (unless it was a forgotten backport)

@StanFromIreland
Copy link
Contributor

StanFromIreland commented Apr 25, 2025

Ah I didn't notice.
It affects main, this should be closed.

@picnixz
Copy link
Member

picnixz commented Apr 25, 2025

Ok, I just checked but main is affected as well. I guess it's fine to remove a redundant check but please open a new PR against main instead (namely, checkout from main, apply your fix, and then open the PR against main instead against 3.13). It will be cleaner than rebasing this onto main.

@picnixz picnixz closed this Apr 25, 2025
@muglug
Copy link
Author

muglug commented Apr 25, 2025

Re-opened against main here: #132972

@muglug muglug deleted the patch-2 branch April 25, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants