Skip to content

gh-132776: Revert Moving memoryview XIData Code to memoryobject.c #132960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 25, 2025
Merged

gh-132776: Revert Moving memoryview XIData Code to memoryobject.c #132960

merged 8 commits into from
Apr 25, 2025

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 25, 2025 •
edited by bedevere-app bot
Loading

This is a partial revert of gh-132821. It resolves the refleak introduced by that PR.

@ericsnowcurrently ericsnowcurrently added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Apr 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 25, 2025
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 25, 2025
Merged
vstinner
vstinner approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the change fix the refleak:

$ ./python -m test test__interpchannels -R 3:3
Result: SUCCESS
$ ./python -m test test_interpreters -R 3:3
Result: SUCCESS

@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) April 25, 2025 16:29
@ericsnowcurrently ericsnowcurrently merged commit 2a28b21 into python:main Apr 25, 2025
51 checks passed
@ericsnowcurrently ericsnowcurrently deleted the fix-memoryview-xid-leak branch April 25, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericsnowcurrently @vstinner