gh-127011: Add __str__ and __repr__ to ConfigParser #132966
Open
+83
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Agent-Hellboy
commented
Apr 25, 2025
•
- Issue: Add __str__ and __repr__ to ConfigParser for Better Debugging and Unit Testing #127011
picnixz
reviewed
Apr 25, 2025
Misc/NEWS.d/next/Library/2025-04-25-18-29-10.gh-issue-127011.Ipem5z.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…pem5z.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
You can batch apply suggestions from the Files Changed tab, please do so. |
picnixz
reviewed
Apr 25, 2025
Misc/NEWS.d/next/Library/2025-04-25-18-29-10.gh-issue-127011.Ipem5z.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
reviewed
Apr 25, 2025
Comment on lines
+1083
to
+1085
| return (f"<{self.__class__.__name__}(" | ||
| f"params={init_params}, " | ||
| f"state={state_summary})>") |
There was a problem hiding this comment.
We could use = f-strings:
return f"<{self.__class__.__name__}({params=}, {state=})>"but this requires the variables to be named "params" and "state" instead.
There was a problem hiding this comment.
I can change if you want but init_params and state_summary are more descriptive for those who are reading the code.
There was a problem hiding this comment.
Mmh, yes. Let's leave keep it that way (I'll let Jaraco have the final say)
picnixz
reviewed
Apr 25, 2025
Comment on lines
+1083
to
+1085
| return (f"<{self.__class__.__name__}(" | ||
| f"params={init_params}, " | ||
| f"state={state_summary})>") |
There was a problem hiding this comment.
Mmh, yes. Let's leave keep it that way (I'll let Jaraco have the final say)
picnixz
reviewed
Apr 26, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
You do not need to click the button to update the branch, if it’s needed a core dev will run it before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.