Skip to content

gh-132388: remove outdated TODO comment in test_hmac.py #133008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

gh-132388: remove outdated TODO comment in test_hmac.py #133008

merged 1 commit into from
Apr 26, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Apr 26, 2025 •
edited by bedevere-app bot
Loading

I don't remember why I put it but I know that it's now outdated. Proof:

/*[clinic input]
_hashlib.hmac_digest as _hashlib_hmac_singleshot

    key: Py_buffer
    msg: Py_buffer
    digest: object

Single-shot HMAC.
[clinic start generated code]*/

@picnixz picnixz requested a review from gpshead as a code owner April 26, 2025 12:53
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Apr 26, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 26, 2025
Closed
@picnixz picnixz enabled auto-merge (squash) April 26, 2025 12:54
@picnixz picnixz merged commit e714ead into python:main Apr 26, 2025
44 checks passed
@picnixz picnixz deleted the cleanup/test/hmac-tests-132388 branch April 26, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@picnixz