GH-128520: pathlib ABCs: raise text encoding warnings at correct stack level #133051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that warnings about unspecified text encodings are emitted from `ReadablePath.read_text()`, `WritablePath.write_text()` and `magic_open()` with the correct stack level set.
17 tasks
JelleZijlstra
approved these changes
Apr 27, 2025
|
Thanks! I can't see any indication that any build bots enable FWIW, when I backport this to the pathlib-abc pypi package, I'll add |
|
I'd prefer if these tests are exercised in some way in CPython's own CI but up to you if you prefer a different approach; feel free to merge as is. |
|
Thanks Jelle. I'll get these tests running in CPython CI in a follow-up PR, because I suspect the same fix will be useful in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that warnings about unspecified text encodings are emitted from
ReadablePath.read_text(),WritablePath.write_text()andmagic_open()with the correct stack level set.These classes/functions are still private, so there's no public change of behaviour.