Skip to content

[tests] fix test_fcntl issue when run in a ChromeOS linux runtime #133053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2025
Merged

[tests] fix test_fcntl issue when run in a ChromeOS linux runtime #133053

merged 2 commits into from
Apr 27, 2025

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Apr 27, 2025

It doesn't appear to support F_NOTIFY? Detect the lack of that and skip the test.

@gpshead gpshead added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.13 bugs and security fixes labels Apr 27, 2025
@gpshead
[tests] test_fcntl fails when run in a ChromeOS linux runtime container.
544cba8 
It doesn't appear to support F_NOTIFY? Detect the lack of that and skip the test.
@gpshead gpshead force-pushed the gpshead/test_fcntl_cros_vm_fix branch from 8c7c405 to 544cba8 Compare April 27, 2025 18:23
@gpshead gpshead changed the title [tests] test_fcntl fails when run in a ChromeOS linux runtime container. [tests] fix test_fcntl issue when run in a ChromeOS linux runtime Apr 27, 2025
@gpshead gpshead merged commit 355ee1a into python:main Apr 27, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2025
@gpshead @miss-islington
[tests] fix test_fcntl issue when run in a ChromeOS linux runtime (py…
86085a4 
…thonGH-133053)

* [tests] test_fcntl fails when run in a ChromeOS linux runtime container.

It doesn't appear to support F_NOTIFY? Detect the lack of that and skip the test.
(cherry picked from commit 355ee1a)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app
Copy link

bedevere-app bot commented Apr 27, 2025

GH-133056 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 27, 2025
gpshead added a commit that referenced this pull request Apr 27, 2025
@miss-islington @gpshead
[3.13] [tests] fix test_fcntl issue when run in a ChromeOS linux runt…
8fdc106 
…ime (GH-133053) (GH-133056)

[tests] fix test_fcntl issue when run in a ChromeOS linux runtime (GH-133053)

* [tests] test_fcntl fails when run in a ChromeOS linux runtime container.

It doesn't appear to support F_NOTIFY? Detect the lack of that and skip the test.
(cherry picked from commit 355ee1a)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.13 (tier-1) has failed when building commit 8fdc106.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1483/builds/654) and take a look at the build logs.
  4. Check if the failure is related to this commit (8fdc106) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1483/builds/654

Failed tests:

  • test.test_multiprocessing_spawn.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_spawn.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.billenstein-macos/build/Lib/test/_test_multiprocessing.py", line 1483, in test_repr_rlock
    self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpshead @bedevere-bot