Skip to content

gh-133054: Skip test_pyrepl tests when cannot use pyrepl is reported #133055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 28, 2025
Merged

gh-133054: Skip test_pyrepl tests when cannot use pyrepl is reported #133055

merged 6 commits into from
Apr 28, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 27, 2025 •
edited by bedevere-app bot
Loading

This can be customized with skip=False if needed.

@sobolevn sobolevn requested a review from skirpichev April 27, 2025 20:03
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Apr 27, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 27, 2025
Closed
@sobolevn @tomasr8
Update Lib/test/test_pyrepl/test_pyrepl.py
c92237a 
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
skirpichev

This comment was marked as resolved.

Sign in to view

@sobolevn
Copy link
Member Author

I've pushed my commit but GitHub has some problems :(

tomasr8
tomasr8 reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to send this yesterday 😅

tomasr8
tomasr8 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit b739ec5 into python:main Apr 28, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b739ec5ab78ed55367516de7a11e732cb3f1081d 3.13

@sobolevn
Copy link
Member Author

I will do a manual backport soon, thanks everyone!

sobolevn added a commit to sobolevn/cpython that referenced this pull request Apr 28, 2025
@sobolevn @tomasr8
[3.13] pythongh-133054: Skip test_pyrepl tests when `cannot use pyr…
d31a036 
…epl` is reported (pythonGH-133055)

(cherry picked from commit b739ec5)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 28, 2025

GH-133095 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 28, 2025
sobolevn added a commit that referenced this pull request Apr 28, 2025
@sobolevn @tomasr8
[3.13] gh-133054: Skip test_pyrepl tests when cannot use pyrepl i…
ab89f6e 
…s reported (GH-133055) (#133095)

(cherry picked from commit b739ec5)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@tomasr8 tomasr8 tomasr8 approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

@sobolevn sobolevn

Labels
awaiting core review skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @skirpichev @tomasr8