-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-132983: Install compression package contents #133063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 New build scheduled with the buildbot fleet by @emmatyping for commit 8c347a1 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133063%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
I added test-with-buildbots to verify this fix corrects the failing buildbots |
Installed tests passed https://buildbot.python.org/#/builders/1285/builds/243 Looks like the M1 free-threaded buildbot failure is not related. |
The macos test failures look unrelated. |
Agree but the check is required, so I can't merge. Restarted the test. |
Looks like this will resolve the iOS test failure as well. |
Now we're blocked from merging by the CLA bot. Feel free to ping me if the CI is fully green and it hasn't been merged yet. |
|
|
|
|
The problem is not yet solved. Is it because there are some missing bits? |
These failures look different from the others. The previous buildbot failure was in tests in the installed python (raising errors about missing It's not clear to me how these errors could be caused by the changes. A loader being None when no code is customizing loaders is deeply weird. |
It could have been me then: #130721. I will check that revert this commit actually solves those failures. |
After investigation, the package causing the issue is |
I confirm that the buildbot failure is caused by this change.
I confirm that adding an |
This fixes a buildbot failure for running tests on installed Python.
Changes in this PR:
compression.*
packages.