gh-132987: Support __index__() in the socket module #133093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntohl(), htonl(), if_indextoname(), getaddrinfo() now use __index__() if available. Also fix the Argument Clinic names for module-level functions (although this does not affect the user).
|
As a side effect, ValueError is now raised instead of OverflowError for negative values. See also #74020. |
vstinner
reviewed
Apr 29, 2025
Comment on lines
+654
to
+660
| class uint16_converter(CConverter): | ||
| type = "uint16_t" | ||
| converter = '_PyLong_UInt16_Converter' | ||
|
|
||
| class uint32_converter(CConverter): | ||
| type = "uint32_t" | ||
| converter = '_PyLong_UInt32_Converter' |
There was a problem hiding this comment.
Would it be possible to move uint16_t and uint32_t converters directly to Argument Clinic as built-in converters?
There was a problem hiding this comment.
I am going to do this in more general way in a separate issue. There are other converters defined in different files.
| } | ||
|
|
||
| UNSIGNED_INT_CONVERTER(UInt16, uint16_t) | ||
| UNSIGNED_INT_CONVERTER(UInt32, uint32_t) |
There was a problem hiding this comment.
You might use PyLong_AsUInt32() for this converter.
There was a problem hiding this comment.
No, PyLong_AsUInt32 cannot be used as a converter. It has wrong signature and returns wrong value.
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ntohl(), htonl(), if_indextoname(), getaddrinfo() now use index() if available.
Also fix the Argument Clinic names for module-level functions (although this does not affect the user).