Skip to content

gh-132987: Support __index__() in the select.kqueue_event constructor #133094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

gh-132987: Support __index__() in the select.kqueue_event constructor #133094

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf48d7c
gh-132987: Support __index__() in the select.kqueue_event constructor
serhiy-storchaka Apr 28, 2025
a1b251d
Fix typo.
serhiy-storchaka Apr 28, 2025
3d7470c
Update Modules/selectmodule.c
serhiy-storchaka Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions Modules/selectmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,14 +1922,27 @@ kqueue_event_init(PyObject *op, PyObject *args, PyObject *kwds)
return -1;
}

if (PyLong_Check(pfd)) {
self->e.ident = PyLong_AsSize_t(pfd);
if (PyIndex_Check(pfd)) {
Py_ssize_t bytes = PyLong_AsNativeBytes(pfd,
&self->e.ident, sizeof(self->e.ident),
Py_ASNATIVEBYTES_NATIVE_ENDIAN |
Py_ASNATIVEBYTES_ALLOW_INDEX |
Py_ASNATIVEBYTES_REJECT_NEGATIVE |
Py_ASNATIVEBYTES_UNSIGNED_BUFFER);
if (bytes < 0) {
return -1;
}
if ((size_t)bytes > sizeof(self->e.ident)) {
PyErr_SetString(PyExc_OverflowError,
"Python int too large for C kqueue event identifier");
return -1;
}
}
else {
self->e.ident = PyObject_AsFileDescriptor(pfd);
}
if (PyErr_Occurred()) {
return -1;
if (PyErr_Occurred()) {
return -1;
}
}
return 0;
}
Expand Down
Loading