gh-132987: Support __index__() in the stat module #133097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it for the mode arguments in filemode(), S_IMODE(), S_ISDIR(), etc.
vstinner
reviewed
Apr 29, 2025
| value = PyLong_AsUnsignedLong(op); | ||
| if ((value == (unsigned long)-1) && PyErr_Occurred()) | ||
| if (PyLong_Check(op)) { | ||
| value = PyLong_AsUnsignedLong(op); |
There was a problem hiding this comment.
This code path looks like a micro-optimization (to avoid PyNumber_Index). I don't think that it's worth it.
There was a problem hiding this comment.
Not only. Many functions like PyLong_AsUnsignedLong() and PyLong_AsUnsignedLongMask(), many setters and converter, only call __index__() if the argument not int. So there would be a subtle behavior difference when the argument is an instance of the int subclass which defines __index__(). And calling __index__() for int subclass adds overhead.
But this is not completely consistent, so this may not make large difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it for the mode arguments in filemode(), S_IMODE(), S_ISDIR(), etc.