Skip to content

gh-132987: Support __index__() in the lzma module #133099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

gh-132987: Support __index__() in the lzma module #133099

merged 3 commits into from
Apr 29, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 28, 2025
Closed
@serhiy-storchaka
Copy link
Member Author

As a side effect, ValueError is now raised instead of OverflowError for negative values. See also #74020.

vstinner
vstinner reviewed Apr 29, 2025
View reviewed changes
vstinner
vstinner approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) April 29, 2025 14:00
@serhiy-storchaka serhiy-storchaka merged commit a64fdc7 into python:main Apr 29, 2025
45 checks passed
@serhiy-storchaka serhiy-storchaka deleted the lzma-unsigned-int-index branch April 29, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@encukou encukou Awaiting requested review from encukou

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @vstinner