gh-132775: Add _PyPickle_GetXIData() #133107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 15ecef1 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133107%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
iritkatriel
reviewed
Apr 30, 2025
Lib/test/support/import_helper.py
Outdated
| @contextlib.contextmanager | ||
| def module_restored(name): | ||
| """A context manager that restores a module to the original state.""" | ||
| missing = name in sys.modules |
There was a problem hiding this comment.
shouldn't missing be name not in sys.modules? (or renamed to present)?
also, is it different than orig is not None?
There was a problem hiding this comment.
Yeah, it should be "not" in sys.modules. Good catch.
It is different from orig is not None since None could be set in sys.modules. I could use a temporary sentinel for that, I suppose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some extra complexity due to making sure we we get things right when handling functions and classes defined in the
__main__module. This is also reflected in the tests, including the addition of extra functions in test.support.import_helper.