Skip to content

gh-133117: Run mypy on tomllib in CI #133118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

gh-133117: Run mypy on tomllib in CI #133118

merged 3 commits into from
Apr 30, 2025
+25 −2

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 28, 2025
Open
@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels Apr 28, 2025
hugovk
hugovk reviewed Apr 29, 2025
View reviewed changes
Lib/tomllib/_parser.py Outdated
@@ -214,7 +214,7 @@ class Flags:
EXPLICIT_NEST = 1

def __init__(self) -> None:
self._flags: dict[str, dict] = {}
self._flags: dict[str, dict[Any, Any]] = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fully typed already, we just need to run the CI if something changes.

Seems it wasn't fully typed already?

Please can you also submit these changes to https://github.com/hukkin/tomli ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do it before or after this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest there first, because we're sort of downstream, but no strong preference from me.

Let's ask @hukkin, @encukou and @hauntsaninja.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: hukkin/tomli#257

@sobolevn sobolevn mentioned this pull request Apr 29, 2025
Merged
AlexWaygood
AlexWaygood reviewed Apr 29, 2025
View reviewed changes
@sobolevn
Copy link
Member Author

merging main so CLA can possibly get unstuck :(

@sobolevn
Copy link
Member Author

I will keep this open for a day or so, waiting for others' feedback :)

@sobolevn sobolevn merged commit 5ea9010 into python:main Apr 30, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2025
@sobolevn @miss-islington
pythongh-133117: Run mypy on tomllib in CI (pythonGH-133118)
b9259e1 
(cherry picked from commit 5ea9010)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Apr 30, 2025

GH-133192 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 30, 2025
@sobolevn
Copy link
Member Author

Now I will work on enabling disallow_any_generics = True, thanks everyone!

sobolevn added a commit that referenced this pull request Apr 30, 2025
@miss-islington @sobolevn
[3.13] gh-133117: Run mypy on tomllib in CI (GH-133118) (#133192)
0458554 
gh-133117: Run mypy on `tomllib` in CI (GH-133118)
(cherry picked from commit 5ea9010)

Co-authored-by: sobolevn <mail@sobolevn.me>
@sobolevn sobolevn mentioned this pull request Apr 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@ambv ambv Awaiting requested review from ambv

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja hauntsaninja is a code owner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @hugovk @AlexWaygood