Lint: Use Ruff for all formatting in pre-commit #133123
Open
+162
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
approved these changes
Apr 29, 2025
| @@ -21,9 +21,7 @@ def _async_cache(f: _C[_P, _R]) -> _C[_P, _R]: | |||
| lock = asyncio.Lock() | |||
|
|
|||
| @functools.wraps(f) | |||
| async def wrapper( | |||
| *args: _P.args, **kwargs: _P.kwargs # pylint: disable = no-member | |||
There was a problem hiding this comment.
did you mean to get rid of various pylint suppression comments in this PR? I assume it was there because it was useful to the JIT developers working on this code
There was a problem hiding this comment.
Oops, I'd meant to add them back after reformatting.
cc @brandtbucher to check that the comments are still useful (we don't run pylint in CI, currently)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make that much sense to use two linters in our source tree. This switches
Tools/jitandTools/build/check-warnings.pyto use Ruff for their formatting, which has the side benefit of slightly speeding uppre-commitand the lint CI job.A