Skip to content

gh-133131: Discover an appropriate iOS simulator rather than hard-coding iPhone SE 3rd gen #133132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Apr 29, 2025

With the release of the iPhone 16e, Xcode 16.3 has been released; this release no longer contains an iPhone SE (3rd generation) simulator by default.

This PR modifies the iOS testbed to search for "SE-class" deployment candidates, rather than hard-coding the iPhone SE as the deployment target if no simulator image is specified.

@freakboy3742 freakboy3742 added the needs backport to 3.13 bugs and security fixes label Apr 29, 2025
@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 3c9e818 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133132%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742 freakboy3742 requested a review from ned-deily April 29, 2025 07:30
@freakboy3742 freakboy3742 merged commit 42b0b06 into python:main Apr 29, 2025
48 checks passed
@freakboy3742 freakboy3742 deleted the ios-default-simulator branch April 29, 2025 21:35
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 29, 2025
…rd-coding iPhone SE 3rd gen (pythonGH-133132)

Determines a candidate simulator at runtime rather than hardcoding iPhone SE.
(cherry picked from commit 42b0b06)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 29, 2025

GH-133173 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 29, 2025
freakboy3742 added a commit that referenced this pull request Apr 29, 2025
…ard-coding iPhone SE 3rd gen (GH-133132) (#133173)

Determines a candidate simulator at runtime rather than hardcoding iPhone SE.
(cherry picked from commit 42b0b06)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Refleaks 3.13 (tier-2) has failed when building commit 7998f99.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1512/builds/562) and take a look at the build logs.
  4. Check if the failure is related to this commit (7998f99) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1512/builds/562

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 393, in test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 535 events and lost 1[34 chars]\n\n' != ''
- Warning:
- Processed 535 events and lost 1 chunks!
- 
- Check IO/CPU overload!
- 


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 393, in test_python_calls_do_not_appear_in_the_stack_if_perf_deactivated
    self.assertEqual(stderr, "")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
AssertionError: 'Warning:\nProcessed 466 events and lost 2[34 chars]\n\n' != ''
- Warning:
- Processed 466 events and lost 2 chunks!
- 
- Check IO/CPU overload!
- 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants