gh-132876: workaround broken ldexp() on Windows 10 #133135
Open
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tim Peters <tim.peters@gmail.com>
|
Some benchmarking in: #132876 (comment) |
tim-one
reviewed
Apr 29, 2025
skirpichev
commented
Apr 29, 2025
tim-one
reviewed
Apr 29, 2025
skirpichev
commented
Apr 29, 2025
skirpichev
commented
Apr 29, 2025
skirpichev
commented
Apr 29, 2025
tim-one
reviewed
Apr 29, 2025
There was a problem hiding this comment.
Since this is a potentially breaking change on Windows, it really needs a NEWS entry, yes? Like
math.ldexp() on Windows failed to round subnormal results before Window 11, and Microsoft probably won't fix it for Windows 10. So Python works around the error on Windows now. This may change results (which were formerly erroneous) in rare cases.
And maybe link to the issue report?
|
It has a NEWS entry, though it could include a bit more detail (such as the ranges of values that may be incorrect). And that entry will already be linked to the bug. So this change LGTM |
zooba
reviewed
Apr 29, 2025
skirpichev
commented
Apr 29, 2025
Misc/NEWS.d/next/Library/2025-04-29-11-48-46.gh-issue-132876.lyTQGZ.rst
Outdated
Show resolved
Hide resolved
skirpichev
commented
Apr 30, 2025
Misc/NEWS.d/next/Library/2025-04-29-11-48-46.gh-issue-132876.lyTQGZ.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2025-04-29-11-48-46.gh-issue-132876.lyTQGZ.rst
Outdated
Show resolved
Hide resolved
tim-one
reviewed
Apr 30, 2025
skirpichev
commented
Apr 30, 2025
skirpichev
commented
Apr 30, 2025
Misc/NEWS.d/next/Library/2025-04-29-11-48-46.gh-issue-132876.lyTQGZ.rst
Outdated
Show resolved
Hide resolved
skirpichev
commented
Apr 30, 2025
Misc/NEWS.d/next/Library/2025-04-29-11-48-46.gh-issue-132876.lyTQGZ.rst
Outdated
Show resolved
Hide resolved
zooba
approved these changes
Apr 30, 2025
tim-one
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ldexp()on Windows doesn't round subnormal results before Windows 11, but should. Python's :func:math.ldexpwrapper now does round them.