gh-131296: Fix clang-cl warning on Windows in posixmodule.c
#133142
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
reviewed
Apr 29, 2025
|
Generally not. We only fix some compilation warnings and did not make obviously change. can refer to #131296 |
chris-eibl
reviewed
Apr 30, 2025
Modules/posixmodule.c
Outdated
| @@ -4189,7 +4189,7 @@ posix_getcwd(int use_bytes) | |||
| /* If the buffer is large enough, len does not include the | |||
| terminating \0. If the buffer is too small, len includes | |||
| the space needed for the terminator. */ | |||
| if (len >= Py_ARRAY_LENGTH(wbuf)) { | |||
| if ((size_t)len >= Py_ARRAY_LENGTH(wbuf)) { | |||
There was a problem hiding this comment.
This does not fix the warning, because it happens in the next line
if (len <= PY_SSIZE_T_MAX / sizeof(wchar_t))
There was a problem hiding this comment.
Oh, I was wrong at the time, but now I've changed it, is there still a problem?
chris-eibl
reviewed
May 2, 2025
| @@ -4190,7 +4190,7 @@ posix_getcwd(int use_bytes) | |||
| terminating \0. If the buffer is too small, len includes | |||
| the space needed for the terminator. */ | |||
| if (len >= Py_ARRAY_LENGTH(wbuf)) { | |||
| if (len <= PY_SSIZE_T_MAX / sizeof(wchar_t)) { | |||
| if ((Py_ssize_t)len <= PY_SSIZE_T_MAX / sizeof(wchar_t)) { | |||
There was a problem hiding this comment.
This indeed fixes the warning. IMHO, that's the most pragmatic fix. We could be fancy and do some #if on sizeof(Py_ssize_t), etc, but I don't think it is worth the hassle.
chris-eibl
approved these changes
May 2, 2025
DangNhutNguyen
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only 1 warning in
posixmodule.cPlease add skip news label :)