gh-133059: Increase _PY_NSMALLPOSINTS size #133160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dg-pb
commented
Apr 29, 2025
•
- Issue: Increase _PY_NSMALLPOSINTS size #133059
nineteendo
reviewed
Apr 30, 2025
| @@ -106,7 +106,7 @@ struct _Py_cached_objects { | |||
| }; | |||
|
|
|||
| // These would be in pycore_long.h if it weren't for an include cycle. | |||
| #define _PY_NSMALLPOSINTS 257 | |||
| #define _PY_NSMALLPOSINTS 1025 | |||
| #define _PY_NSMALLNEGINTS 5 | |||
There was a problem hiding this comment.
How about negative integers?
There was a problem hiding this comment.
Someone could indeed explore that too, but probability that it turns out that there is significant evidence to increase it is not very high.
See initial findings at faster-cpython/ideas#725 (comment)
And also, very first graph in #133059 (comment) does include negatives too. It can not be seen clearly in the graph, but there are 193 below -5, while total is 117556.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.