gh-131798: JIT: Narrow the return type of isinstance for some known arguments
#133172
+363
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
commented
Apr 29, 2025
| // isinstance(obj, cls) where both obj and cls have known types | ||
| // We can deduce either True or False | ||
| PyTypeObject *inst_type = sym_get_type(inst_sym); | ||
| if (sym_matches_type(inst_sym, cls) || PyType_IsSubtype(inst_type, cls)) { |
There was a problem hiding this comment.
This simulates PyObject_TypeCheck
| @@ -886,6 +886,44 @@ dummy_func(void) { | |||
| } | |||
| } | |||
|
|
|||
| op(_CALL_ISINSTANCE, (callable, self_or_null, args[oparg] -- res)) { | |||
| if (sym_is_null(self_or_null) || sym_is_not_null(self_or_null)) { | |||
There was a problem hiding this comment.
I've seen this guard used elsewhere with self_or_null but it's not clear to me whether it is needed here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
isintance(obj, cls)toTrueif obj is a known type and cls is a known class and obj is a subclass of cls (and vice versa forFalse)isinstancetobool.Brandt also suggested adding an optimization for tuples which I'd like to add in a followup in order to keep the sizes of the individual PRs smaller. Though if you prefer to have it in one PR I can do it as well :)