Skip to content

Fix typo at _interpretersmodule.c file #133174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

nybblista
Copy link
Contributor

Fix the typo in the is_running_main function comment.

@nybblista
Copy link
Contributor Author

@picnixz

@StanFromIreland
Copy link
Contributor

StanFromIreland commented Apr 30, 2025

This is pointless and should be closed, it is not user facing and barely a typo.

@ZeroIntensity
Copy link
Member

Yes, it's not user-facing, but it's CPython-facing! There aren't many experts on _interpreters, and I see no reason why we shouldn't fix comments explaining how it works. I agree that we should not set a precedent for future copycat PRs fixing typos, though.

@StanFromIreland
Copy link
Contributor

StanFromIreland commented Apr 30, 2025

Is it really a fix of any importance though? I can read it fine without the space, I would assume most people can too.

@ZeroIntensity
Copy link
Member

Fixes without priority still have importance. If we want to close this because it's "churn," that's probably fine, but keep in mind that there is real merit to keeping comments in check, especially in parts of the codebase that lack experts.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Peter -- though I'm not a huge fan of typo-only PRs, this one does seem somewhat beneficial.

A

@AA-Turner AA-Turner merged commit b99d970 into python:main May 1, 2025
55 checks passed
@nybblista nybblista deleted the fix-typo-interpreter-module branch May 1, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants