-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-131531: Make Android build retry after network failures #133193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
!buildbot android |
🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 4c83a6b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133193%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess time will tell whether 5 retries is enough. Otherwise, looks like a solid collection of cleanups.
Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…honGH-133193) Adds a retry strategy when downloading compilation resources for Android, plus some other cleanups. (cherry picked from commit feac343) Co-authored-by: Malcolm Smith <smith@chaquo.com>
GH-133236 is a backport of this pull request to the 3.13 branch. |
This commit was cherry-picked from #132870, because the buildbots have had a lot of intermittent download failures from GitHub URLs in the last few days.
It uses curl's
--retry-all-errors
flag, because some of the failures have returned codes that indicate a permanent failure (e.g. 403), even though it's actually temporary.Other cleanups:
shutil.unpack_archive
to remove the dependency on an externaltar
command.