Skip to content

gh-131031: Fix separated running of pickle tests #133218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Apr 30, 2025

I found that tests stopped running successfully directly after this commit (PR #122373)

@donBarbos donBarbos changed the title Fix separated running of pickle tests gh-131031: Fix separated running of pickle tests Apr 30, 2025
@donBarbos
Copy link
Contributor Author

cc @tomasr8 (sorry for choosing you but current pickle expert is inactive)

@tomasr8
Copy link
Member

tomasr8 commented Apr 30, 2025

Are you sure the assertions are being executed? Since self.dumps(obj, proto) raises, anything that comes after in the with block will not execute.

@donBarbos donBarbos marked this pull request as draft May 1, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants