gh-132775: Add _PyCode_VerifyStateless() #133221
Open
+441
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
reviewed
Apr 30, 2025
Include/internal/pycore_code.h
Outdated
|
|
||
| /* "Stateless" code is a function or code object which does not rely on | ||
| * external state or internal state. It may rely on arguments and | ||
| * builtins, but not globals or a closure. Thus it does not need to |
There was a problem hiding this comment.
Suggested change
| * builtins, but not globals or a closure. Thus it does not need to | |
| * builtins, but not globals or a closure. Thus it does not |
Include/internal/pycore_code.h
Outdated
| * Stateless code that takes no arguments and doesn't return anything | ||
| * may be treated like a script. | ||
| * | ||
| * Note that we can consider stateless code to be |
There was a problem hiding this comment.
Suggested change
| * Note that we can consider stateless code to be | |
| * We consider stateless code to be |
Objects/codeobject.c
Outdated
| } | ||
| // We may consider relaxing these if it becomes a problem. | ||
| errmsg = _PyCode_CheckNoInternalState(co); | ||
| if (errmsg != NULL) { |
There was a problem hiding this comment.
The convention is NULL means error and non-null is not error. I don't think it's a good idea to do the opposite here.
There was a problem hiding this comment.
The function cannot fail, but I see what you are saying. I'll change this.
| } | ||
|
|
||
| if (errmsg != NULL) { | ||
| if (p_errmsg != NULL) { |
There was a problem hiding this comment.
If p_errmsg can be NULL, then the cases above need a check too, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Stateless" code is a function or code object which does not rely on external state or internal state. It may rely on arguments and
builtins, but not globals or a closure. I've left a comment in pycore_code.h that provides more detail.
We also add
_PyFunction_VerifyStateless(). The new functions will be used in several later changes that facilitate "sharing" functions and code objects between interpreters.