Skip to content

gh-133166: Fix missing error emission of PyType_GetModuleByDef #133240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 1, 2025
Merged

gh-133166: Fix missing error emission of PyType_GetModuleByDef #133240

merged 4 commits into from
May 1, 2025
+35 −7

Conversation

neonene
Copy link
Contributor

@neonene neonene commented May 1, 2025 •
edited by bedevere-app bot
Loading

@neonene neonene requested a review from markshannon as a code owner May 1, 2025 07:05
@bedevere-app bedevere-app bot mentioned this pull request May 1, 2025
Closed
@neonene
Copy link
Contributor Author

neonene commented May 1, 2025

@encukou I wonder if you could review this patch.

@encukou encukou merged commit fa52f28 into python:main May 1, 2025
44 checks passed
@encukou encukou added the needs backport to 3.13 bugs and security fixes label May 1, 2025
@miss-islington-app
Copy link

Thanks @neonene for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @neonene and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fa52f289a36f50d6d10e57d485e5a4f58261222b 3.13

@neonene neonene deleted the excbydef branch May 1, 2025 13:28
@encukou encukou removed the needs backport to 3.13 bugs and security fixes label May 1, 2025
@encukou encukou removed their assignment May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neonene @encukou