Skip to content

gh-133210: Fix test_inspect in --without-doc-strings mode #133250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

gh-133210: Fix test_inspect in --without-doc-strings mode #133250

merged 1 commit into from
May 1, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 1, 2025 •
edited
Loading

One module per PR will be much easier to backport and review.

Local check with make clean && ./configure --with-pydebug --without-doc-strings && make -j$(sysctl -n hw.ncpu):

OK (skipped=46)
0:00:00 load avg: 3.68 [1/1] test_inspect.test_inspect passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 646 ms
Total tests: run=354 skipped=46
Total test files: run=1/1
Result: SUCCESS

@sobolevn sobolevn requested a review from vstinner May 1, 2025 12:30
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 1, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 1, 2025
Open
@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels May 1, 2025
vstinner
vstinner approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn sobolevn merged commit 27e0114 into python:main May 1, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 1, 2025
@sobolevn @miss-islington
pythongh-133210: Fix test_inspect in --without-doc-strings mode (p…
831ee60 
…ythonGH-133250)

(cherry picked from commit 27e0114)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented May 1, 2025

GH-133263 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 1, 2025
sobolevn added a commit that referenced this pull request May 1, 2025
@miss-islington @sobolevn
[3.13] gh-133210: Fix test_inspect in --without-doc-strings mode (G…
f7d1109 
…H-133250) (#133263)

gh-133210: Fix `test_inspect` in `--without-doc-strings` mode (GH-133250)
(cherry picked from commit 27e0114)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @vstinner