Skip to content

gh-133017: Improve error message for invalid typecodes in multiprocessing.{Array,Value} #133252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+22 −1
Open

gh-133017: Improve error message for invalid typecodes in multiprocessing.{Array,Value} #133252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62d6671
Improve invalid typecode message
tomasr8 Apr 26, 2025
3ae6818
Add news entry
tomasr8 Apr 26, 2025
9ec5990
Make linter happy
tomasr8 May 1, 2025
03776cc
Fix news entry
tomasr8 May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Lib/multiprocessing/sharedctypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@
#

def _new_value(type_):
size = ctypes.sizeof(type_)
try:
size = ctypes.sizeof(type_)
except TypeError as e:
raise TypeError("bad typecode (must be a ctypes type or one of "
"c, b, B, u, h, H, i, I, l, L, q, Q, f or d)") from e

wrapper = heap.BufferWrapper(size)
return rebuild_ctype(type_, wrapper, None)

Expand Down
12 changes: 12 additions & 0 deletions Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2463,6 +2463,12 @@ def test_getobj_getlock(self):
self.assertNotHasAttr(arr5, 'get_lock')
self.assertNotHasAttr(arr5, 'get_obj')

@unittest.skipIf(c_int is None, "requires _ctypes")
def test_invalid_typecode(self):
with self.assertRaisesRegex(TypeError, 'bad typecode'):
self.Value('x', None)
with self.assertRaisesRegex(TypeError, 'bad typecode'):
self.RawValue('x', None)

class _TestArray(BaseTestCase):

Expand Down Expand Up @@ -2543,6 +2549,12 @@ def test_getobj_getlock_obj(self):
self.assertNotHasAttr(arr5, 'get_lock')
self.assertNotHasAttr(arr5, 'get_obj')

@unittest.skipIf(c_int is None, "requires _ctypes")
def test_invalid_typecode(self):
with self.assertRaisesRegex(TypeError, 'bad typecode'):
self.Array('x', [])
with self.assertRaisesRegex(TypeError, 'bad typecode'):
self.RawArray('x', [])
#
#
#
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Library/2025-05-01-16-03-11.gh-issue-133017.k7RLQp.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Improve the error message of :func:`multiprocessing.sharedctypes.Array`,
:func:`multiprocessing.sharedctypes.RawArray`, :func:`multiprocessing.sharedctypes.Value` and
:func:`multiprocessing.sharedctypes.RawValue` when an invalid typecode is passed. Patch
by Tomas Roun
Loading