Skip to content

gh-133258: fix crash in test_index #133262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

gh-133258: fix crash in test_index #133262

merged 1 commit into from
May 1, 2025

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 1, 2025

@iritkatriel
Copy link
Member Author

!buildbot refleak

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 88b7f62 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133262%2Fmerge

The command will test the builders whose names match following regular expression: refleak

The builders matched are:

  • aarch64 Fedora Rawhide Refleaks PR
  • aarch64 CentOS9 Refleaks PR
  • PPC64LE CentOS9 Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • AMD64 Fedora Rawhide Refleaks PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • AMD64 Fedora Stable Refleaks PR
  • s390x Fedora Rawhide NoGIL refleaks PR
  • AMD64 CentOS9 Refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR
  • PPC64LE Fedora Stable Refleaks PR
  • AMD64 FreeBSD Refleaks PR
  • aarch64 RHEL8 Refleaks PR
  • s390x Fedora Stable Refleaks PR
  • s390x RHEL9 Refleaks PR
  • s390x RHEL8 Refleaks PR
  • AMD64 RHEL8 Refleaks PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 CentOS9 NoGIL Refleaks PR
  • aarch64 Fedora Stable Refleaks PR

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wrote a similar fix locally :-)

@ambv ambv merged commit a4be3bc into python:main May 1, 2025
83 of 86 checks passed
@ambv
Copy link
Contributor

ambv commented May 1, 2025

This fixed the issue on Linux, macOS, and Windows 11 for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants