Skip to content

gh-133300: argparse: make suggest_on_error a keyword-only parameter #133302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

gh-133300: argparse: make suggest_on_error a keyword-only parameter #133302

merged 1 commit into from
May 2, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented May 2, 2025 •
edited by github-actions bot
Loading

@hugovk hugovk added the type-feature A feature request or enhancement label May 2, 2025
@hugovk hugovk requested a review from savannahostrowski as a code owner May 2, 2025 14:26
@bedevere-app bedevere-app bot mentioned this pull request May 2, 2025
Closed
tomasr8
tomasr8 approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! suggest_on_error is new in 3.14 so we can safely make this change.

serhiy-storchaka
serhiy-storchaka approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovk hugovk merged commit e6c518d into python:main May 2, 2025
45 of 48 checks passed
@hugovk hugovk deleted the 3.14-argparse-keyword branch May 2, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@tomasr8 tomasr8 tomasr8 approved these changes

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @serhiy-storchaka @tomasr8