gh-126008: Improve docstrings for Tkinter cget and configure methods #133303
+68
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
May 2, 2025
•
- Explain the behavior of Widget.configure() depending on arguments.
- Unify descriptions.
- Replace "resource" with "option".
- Issue: Tkinter ttk widgets cget() returning _tkinter.Tcl_Obj instead of str #126008
…thods * Explain the behavior of Widget.configure() depending on arguments. * Unify descriptions. * Replace "resource" with "option".
tomasr8
reviewed
May 2, 2025
| option(s) to have the given value(s); in this case the | ||
| command returns an empty string. The following options | ||
| are supported: | ||
| """Query or modify the configuration options for window TAGORID. |
There was a problem hiding this comment.
It took me a while to understand what TAGORID meant, maybe it'd be better if we match the parameter name, i.e. use tarOrId (and similar for the other cases)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.