Skip to content

gh-133403: Type Tools/build/update_file.py and check it with mypy #133404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

gh-133403: Type Tools/build/update_file.py and check it with mypy #133404

merged 3 commits into from
May 7, 2025
+26 −4

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 4, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 4, 2025
Open
hugovk
hugovk approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @AlexWaygood

@sobolevn sobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 7, 2025
@sobolevn sobolevn merged commit 50b52cb into python:main May 7, 2025
42 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 7, 2025
@sobolevn @miss-islington
pythongh-133403: Type Tools/build/update_file.py and check it with …
189317e 
…`mypy` (pythonGH-133404)

(cherry picked from commit 50b52cb)

Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 50b52cba2d13a1854bc835412ac3f3c0ad42b5ba 3.13

@bedevere-app
Copy link

bedevere-app bot commented May 7, 2025

GH-133603 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 7, 2025
sobolevn added a commit that referenced this pull request May 8, 2025
@miss-islington @sobolevn @zware
[3.14] gh-133403: Type Tools/build/update_file.py and check it with…
e8c279f 
… `mypy` (GH-133404) (#133603)

gh-133403: Type `Tools/build/update_file.py` and check it with `mypy` (GH-133404)
(cherry picked from commit 50b52cb)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Zachary Ware <zach@python.org>
sobolevn added a commit to sobolevn/cpython that referenced this pull request May 8, 2025
@sobolevn
[3.13] pythongh-133403: Type Tools/build/update_file.py and check i…
7313bc4 
…t with `mypy` (pythonGH-133404)

(cherry picked from commit 50b52cb)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented May 8, 2025

GH-133637 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 8, 2025
sobolevn added a commit that referenced this pull request May 8, 2025
@sobolevn
[3.13] gh-133403: Type Tools/build/update_file.py and check it with…
aed613f 
… `mypy` (GH-133404) (#133637)

(cherry picked from commit 50b52cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@emmatyping emmatyping emmatyping approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees

@sobolevn sobolevn

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @hugovk @emmatyping