GH-133410: Use commit hashes for change detection #133416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
May 5, 2025
|
Thanks @AA-Turner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @AA-Turner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 5, 2025
) (cherry picked from commit d530e74) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 5, 2025
) (cherry picked from commit d530e74) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-133426 is a backport of this pull request to the 3.12 branch. |
|
GH-133427 is a backport of this pull request to the 3.13 branch. |
|
Also needs backporting to 3.12 so the CI isn't skipped there. |
JelleZijlstra
pushed a commit
that referenced
this pull request
May 5, 2025
Yhg1s
pushed a commit
that referenced
this pull request
May 5, 2025
|
I believe this broke change detection in personal/forked branches prefixed with e.g. |
|
Oh yes, let's fix that :) |
|
Similarly, it's broken on the upstream 3.12-3.14 branches, for the post-merge runs: |
hugovk
added a commit
to hugovk/cpython
that referenced
this pull request
May 8, 2025
…ongh-133416)" This reverts commit d530e74.
|
Let's continue in the issue, #133410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen recently, if the pull-request branch on a fork repository has the same name as the target branch on the upstream repository, the branches shadow each other when set up by
@actions/checkout, meaning that change detection passes with no changes having occured.This changes to instead perform the
git diffwith the commit SHA of the head commit. This is slightly tricky due to what GitHub exposes, but in short, we always compare the tip of the PR branch (fork) against the default branch (upstream).A
cc @JelleZijlstra
Tools/build/compute-changes.pylooks at the wrong branches #133410