Skip to content

GH-133336: Remove reserved -J flag for Jython #133444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions Doc/using/cmdline.rst
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,13 @@ Miscellaneous options
.. versionchanged:: 3.10
Removed the ``-X oldparser`` option.

.. versionremoved:: next

:option:`!-J` is no longer reserved for use by Jython_,
and now has no special meaning.

.. _Jython: https://www.jython.org/

.. _using-on-controlling-color:

Controlling color
Expand All @@ -694,15 +701,6 @@ output. To control the color output only in the Python interpreter, the
precedence over ``NO_COLOR``, which in turn takes precedence over
``FORCE_COLOR``.

Options you shouldn't use
~~~~~~~~~~~~~~~~~~~~~~~~~

.. option:: -J

Reserved for use by Jython_.

.. _Jython: https://www.jython.org/


.. _using-on-envvars:

Expand Down
2 changes: 1 addition & 1 deletion Doc/whatsnew/2.6.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1747,7 +1747,7 @@ Interpreter Changes
-------------------------------

Two command-line options have been reserved for use by other Python
implementations. The :option:`-J` switch has been reserved for use by
implementations. The :option:`!-J` switch has been reserved for use by
Jython for Jython-specific options, such as switches that are passed to
the underlying JVM. :option:`-X` has been reserved for options
specific to a particular implementation of Python such as CPython,
Expand Down
5 changes: 5 additions & 0 deletions Doc/whatsnew/3.14.rst
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,11 @@ Other language changes
:keyword:`async with`).
(Contributed by Bénédikt Tran in :gh:`128398`.)

* :option:`!-J` is no longer a reserved flag for Jython_,
and now has no special meaning.
(Contributed by Adam Turner in :gh:`133336`.)

.. _Jython: https://www.jython.org/

.. _whatsnew314-pep765:

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:option:`!-J` is no longer reserved for use by Jython.
Patch by Adam Turner.
9 changes: 1 addition & 8 deletions Python/getopt.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ static const wchar_t *opt_ptr = L"";

/* Python command line short and long options */

#define SHORT_OPTS L"bBc:dEhiIJm:OPqRsStuvVW:xX:?"
#define SHORT_OPTS L"bBc:dEhiIm:OPqRsStuvVW:xX:?"

static const _PyOS_LongOption longopts[] = {
/* name, has_arg, val (used in switch in initconfig.c) */
Expand Down Expand Up @@ -133,13 +133,6 @@ int _PyOS_GetOpt(Py_ssize_t argc, wchar_t * const *argv, int *longindex)
return opt->val;
}

if (option == 'J') {
if (_PyOS_opterr) {
fprintf(stderr, "-J is reserved for Jython\n");
}
return '_';
}

if ((ptr = wcschr(SHORT_OPTS, option)) == NULL) {
if (_PyOS_opterr) {
fprintf(stderr, "Unknown option: -%c\n", (char)option);
Expand Down
Loading