Skip to content

gh-133530: Improve heapq documenation #133531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Doc/library/heapq-binary-tree.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be an SVG?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason?

I used png since that is what hashlibs diagram uses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpython/Doc/library$ find . -name '*.png'
./pathlib-inheritance.png
./tk_msg.png
./tulip_coro.png
./hashlib-blake2-tree.png
./turtle-star.png
./kde_example.png
cpython/Doc/library$ find . -name '*.svg'
./pathlib-inheritance.svg

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
49 changes: 13 additions & 36 deletions Doc/library/heapq.rst
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ The module also offers three general purpose functions based on heaps.
*reverse* is a boolean value. If set to ``True``, then the input elements
are merged as if each comparison were reversed. To achieve behavior similar
to ``sorted(itertools.chain(*iterables), reverse=True)``, all iterables must
be sorted from largest to smallest.
be sorted from largest to smallest, like for example, a max-heap.

.. versionchanged:: 3.5
Added the optional *key* and *reverse* parameters.
Expand Down Expand Up @@ -306,23 +306,17 @@ entry as removed and add a new entry with the revised priority::
Theory
------

Heaps are arrays for which ``a[k] <= a[2*k+1]`` and ``a[k] <= a[2*k+2]`` for all
*k*, counting elements from 0. For the sake of comparison, non-existing
Min-heaps are arrays for which ``a[k] <= a[2*k+1]`` and ``a[k] <= a[2*k+2]`` for
all *k*, counting elements from 0. For the sake of comparison, non-existing
elements are considered to be infinite. The interesting property of a heap is
that ``a[0]`` is always its smallest element.
that ``a[0]`` is always its smallest element. Max-heaps are the reverse.
Comment on lines +309 to +312
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to default to "heap" being a "min-heap", and then introduce "max-heap" afterwards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is what is done elsewhere.

I changed it here for clarity.


The strange invariant above is meant to be an efficient memory representation
for a tournament. The numbers below are *k*, not ``a[k]``::
for a tournament. The numbers below are *k*, not ``a[k]``:

0

1 2

3 4 5 6

7 8 9 10 11 12 13 14

15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
.. figure:: heapq-binary-tree.png
:align: center
:alt: Example (min-heap) binary tree.

In the tree above, each cell *k* is topping ``2*k+1`` and ``2*k+2``. In a usual
binary tournament we see in sports, each cell is the winner over the two cells
Expand All @@ -346,19 +340,18 @@ last 0'th element you extracted. This is especially useful in simulation
contexts, where the tree holds all incoming events, and the "win" condition
means the smallest scheduled time. When an event schedules other events for
execution, they are scheduled into the future, so they can easily go into the
heap. So, a heap is a good structure for implementing schedulers (this is what
I used for my MIDI sequencer :-).
Comment on lines -349 to -350
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame to 'sterilise' things by removing lines like this. If you feel strongly, perhaps rework to keep the example but remove the perpendicular pronoun.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #62480 for arguments for removing personal notes. Do we need an even more specific example, IMO the general example is fine. Again, this is formal, technical documentation — not a blog post.

heap. So, a heap is a suitable structure for implementing schedulers.

Various structures for implementing schedulers have been extensively studied,
and heaps are good for this, as they are reasonably speedy, the speed is almost
constant, and the worst case is not much different than the average case.
However, there are other representations which are more efficient overall, yet
the worst cases might be terrible.

Heaps are also very useful in big disk sorts. You most probably all know that a
big sort implies producing "runs" (which are pre-sorted sequences, whose size is
Heaps are also very useful in big disk sorts. A
big sort implies producing "runs" (pre-sorted sequences, whose size is
Comment on lines +351 to +352
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more formal? I thought that is what documentation should be…?

usually related to the amount of CPU memory), followed by a merging passes for
these runs, which merging is often very cleverly organised [#]_. It is very
these runs, which merging is often very cleverly organised. It is very
important that the initial sort produces the longest runs possible. Tournaments
are a good way to achieve that. If, using all the memory available to hold a
tournament, you replace and percolate items that happen to fit the current run,
Expand All @@ -370,20 +363,4 @@ in the current tournament (because the value "wins" over the last output value),
it cannot fit in the heap, so the size of the heap decreases. The freed memory
could be cleverly reused immediately for progressively building a second heap,
which grows at exactly the same rate the first heap is melting. When the first
heap completely vanishes, you switch heaps and start a new run. Clever and
quite effective!

In a word, heaps are useful memory structures to know. I use them in a few
applications, and I think it is good to keep a 'heap' module around. :-)

.. rubric:: Footnotes

.. [#] The disk balancing algorithms which are current, nowadays, are more annoying
than clever, and this is a consequence of the seeking capabilities of the disks.
On devices which cannot seek, like big tape drives, the story was quite
different, and one had to be very clever to ensure (far in advance) that each
tape movement will be the most effective possible (that is, will best
participate at "progressing" the merge). Some tapes were even able to read
backwards, and this was also used to avoid the rewinding time. Believe me, real
good tape sorts were quite spectacular to watch! From all times, sorting has
always been a Great Art! :-)
Comment on lines -373 to -389
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is there to keep there? It is a largely a personal note and if I were to strip it to the core information it is irrelevant anyway.

Do you not want formal documentation?

heap completely vanishes, you switch heaps and start a new run.
Loading