Skip to content

gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 #133574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-133580: add missing exception in _sys_getwindowsversion_from_kernel32 #133574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc09ad
add missing exception in _sys_getwindowsversion_from_kernel32
maxbachmann May 7, 2025
064806d
📜🤖 Added by blurb_it.
blurb-it[bot] May 7, 2025
5e5552b
Update Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.j…
maxbachmann May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Windows/2025-05-07-13-04-22.gh-issue-133580.jBMujJ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix :func:`sys.getwindowsversion` failing without setting an exception when called on some WinAPI partitions.
1 change: 1 addition & 0 deletions Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,6 +1643,7 @@ static PyObject *
_sys_getwindowsversion_from_kernel32(void)
{
#ifndef MS_WINDOWS_DESKTOP
PyErr_SetFromWindowsErr(0);
return NULL;
#else
HANDLE hKernel32;
Expand Down
Loading