Skip to content

gh-133551: Skip annotationlib for now in ast roundtrip tests #133634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

gh-133551: Skip annotationlib for now in ast roundtrip tests #133634

merged 1 commit into from
May 8, 2025

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 8, 2025 •
edited by bedevere-app bot
Loading

Currently t"" doesn't roundtrip. I'll put up a PR to fix that but in the meantime this fixes the buildbots.

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 8, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 8, 2025
Closed
@JelleZijlstra JelleZijlstra merged commit 0a3ccb8 into python:main May 8, 2025
44 checks passed
@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@miss-islington-app
Copy link

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the fixbuild branch May 8, 2025 02:36
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2025
@JelleZijlstra @miss-islington
pythongh-133551: Skip annotationlib for now in ast roundtrip tests (p…
675d900 
…ythonGH-133634)

(cherry picked from commit 0a3ccb8)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 8, 2025

GH-133636 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025
JelleZijlstra added a commit that referenced this pull request May 8, 2025
@miss-islington @JelleZijlstra
[3.14] gh-133551: Skip annotationlib for now in ast roundtrip tests (G…
f12e576 
…H-133634) (#133636)

gh-133551: Skip annotationlib for now in ast roundtrip tests (GH-133634)
(cherry picked from commit 0a3ccb8)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 Refleaks 3.14 (tier-2) has failed when building commit f12e576.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1777/builds/2) and take a look at the build logs.
  4. Check if the failure is related to this commit (f12e576) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1777/builds/2

Failed tests:

  • test.test_multiprocessing_spawn.test_processes

Failed subtests:

  • test_interrupt - test.test_multiprocessing_spawn.test_processes.WithProcessesTestProcess.test_interrupt

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "<string>", line 1, in <module>
    from multiprocessing.spawn import spawn_main; spawn_main(tracker_fd=6, pipe_handle=8)
                                                  ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/spawn.py", line 122, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/spawn.py", line 132, in _main
    self = reduction.pickle.load(from_parent)
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_multiprocessing_spawn/test_processes.py", line 2, in <module>
    from test._test_multiprocessing import install_tests_in_module_dict
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/_test_multiprocessing.py", line 67, in <module>
    from multiprocessing.sharedctypes import Value, copy
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/sharedctypes.py", line 212, in <module>
    class Synchronized(SynchronizedBase):
        value = make_property('value')
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/sharedctypes.py", line 213, in Synchronized
    value = make_property('value')
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/sharedctypes.py", line 153, in make_property
    exec(template % ((name,)*7), d)
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 0, in <module>
    
    
    from multiprocessing.spawn import spawn_main; spawn_main(tracker_fd=6, pipe_handle=8)
    
KeyboardInterrupt
FAIL


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/sharedctypes.py", line 150, in make_property
    return prop_cache[name]
           ~~~~~~~~~~^^^^^^
KeyError: 'value'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/_test_multiprocessing.py", line 578, in test_interrupt
    self.assertEqual(exitcode, 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
AssertionError: -2 != 1


Traceback (most recent call last):
  File "<string>", line 1, in <module>
    from multiprocessing.spawn import spawn_main; spawn_main(tracker_fd=7, pipe_handle=9)
                                                  ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/spawn.py", line 122, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/spawn.py", line 132, in _main
    self = reduction.pickle.load(from_parent)
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_multiprocessing_spawn/test_processes.py", line 2, in <module>
    from test._test_multiprocessing import install_tests_in_module_dict
  File "<frozen importlib._bootstrap>", line 1371, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1342, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 938, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 758, in exec_module
  File "<frozen importlib._bootstrap_external>", line 891, in get_code
  File "<frozen importlib._bootstrap_external>", line 514, in _compile_bytecode
KeyboardInterrupt
FAIL


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/process.py", line 320, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/_test_multiprocessing.py", line 513, in _sleep_some
    time.sleep(100)
    ~~~~~~~~~~^^^^^
KeyboardInterrupt
k

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@JelleZijlstra @Pranjal095
pythongh-133551: Skip annotationlib for now in ast roundtrip tests (p…
a384253 
…ython#133634)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@JelleZijlstra @taegyunkim
pythongh-133551: Skip annotationlib for now in ast roundtrip tests (p…
68ebdbb 
…ython#133634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @bedevere-bot