Skip to content

gh-133644: remove deprecated PyImport_ImportModuleNoBlock #133655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 8, 2025
Merged

gh-133644: remove deprecated PyImport_ImportModuleNoBlock #133655

merged 6 commits into from
May 8, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented May 8, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 8, 2025
Open
7 tasks
vstinner
vstinner reviewed May 8, 2025
View reviewed changes
@vstinner
Copy link
Member

vstinner commented May 8, 2025

A search on PyPI top 8,000 projects found usage in 2 projects:

  • dukpy (0.5.0)
  • google-cloud-profiler (4.1.0)
dukpy-0.5.0.tar.gz: dukpy-0.5.0/src/capsulethunk.h: object = PyImport_ImportModuleNoBlock(trace);

google-cloud-profiler-4.1.0.tar.gz: google-cloud-profiler-4.1.0/googlecloudprofiler/src/log.cc: logging = PyImport_ImportModuleNoBlock("logging");

vstinner
vstinner approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz picnixz enabled auto-merge (squash) May 8, 2025 12:57
@picnixz picnixz merged commit a2c4467 into python:main May 8, 2025
43 checks passed
@picnixz picnixz deleted the cleanup/315/deprecated-import-133644 branch May 8, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @vstinner