Skip to content

GH-132983: PEP 7 and Argument Clinic changes for zstd #133791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 10, 2025
Merged

GH-132983: PEP 7 and Argument Clinic changes for zstd #133791

merged 4 commits into from
May 10, 2025
+132 −151

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented May 9, 2025 •
edited by bedevere-app bot
Loading

  • Remove leading underscore from module-level functions
  • Fix __module__ for zstd types implemented in C
  • PEP 7 style conformance
  • Make more things static

@AA-Turner AA-Turner requested review from emmatyping and picnixz May 9, 2025 23:33
@AA-Turner AA-Turner added skip news needs backport to 3.14 bugs and security fixes labels May 9, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 9, 2025
Open
11 tasks
emmatyping
emmatyping approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Once it's landed I will go through and refactor the code to use more idiomatic locking patterns.

@AA-Turner AA-Turner enabled auto-merge (squash) May 10, 2025 00:17
@AA-Turner AA-Turner merged commit 1978904 into python:main May 10, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2025
@AA-Turner @miss-islington
pythonGH-132983: PEP 7 and Argument Clinic changes for zstd (pythonGH…
807082d 
…-133791)

(cherry picked from commit 1978904)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2025

GH-133792 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 10, 2025
@AA-Turner AA-Turner deleted the zstd-clinic branch May 10, 2025 00:34
AA-Turner added a commit that referenced this pull request May 10, 2025
@miss-islington @AA-Turner
[3.14] GH-132983: PEP 7 and Argument Clinic changes for zstd (GH-133791…
d9571c9 
…) (#133792)

GH-132983: PEP 7 and Argument Clinic changes for zstd (GH-133791)
(cherry picked from commit 1978904)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

@picnixz picnixz Awaiting requested review from picnixz

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @emmatyping