Skip to content

Fix incorrect error type in math.factorial documentation (GH-133904) #133913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix incorrect error type in math.factorial documentation (GH-133904) #133913

wants to merge 1 commit into from

Conversation

abhigyan631
Copy link

@abhigyan631 abhigyan631 commented May 12, 2025 •
edited by github-actions bot
Loading

@python-cla-bot
Copy link

python-cla-bot bot commented May 12, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request May 12, 2025
Closed
@bedevere-app
Copy link

bedevere-app bot commented May 12, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@skirpichev skirpichev added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 12, 2025
@skirpichev
Copy link
Contributor

@abhigyan631, you shouldn't modify auto-generated files by hand. Instead, make changes in Module/mathmodule.c and run make clinic. Please take look on https://devguide.python.org/.

BTW, someone already works on this issue: #133907

@abhigyan631
Copy link
Author

@abhigyan631, you shouldn't modify auto-generated files by hand. Instead, make changes in Module/mathmodule.c and run make clinic. Please take look on https://devguide.python.org/.

BTW, someone already works on this issue: #133907

Ok thank you for the reference provided. Will make sure from next time.

@skirpichev
Copy link
Contributor

Lets close this in favor of #133907

@skirpichev skirpichev closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhigyan631 @skirpichev